Skip to content

fix: point the extension's dashboard links at the current path-scoped URLs#617

Open
JulianMaurin wants to merge 1 commit into
mainfrom
devs/JulianMaurin/MRGFY-7874/point-extension-s-dashboard-links-current-path--3ea0d77e
Open

fix: point the extension's dashboard links at the current path-scoped URLs#617
JulianMaurin wants to merge 1 commit into
mainfrom
devs/JulianMaurin/MRGFY-7874/point-extension-s-dashboard-links-current-path--3ea0d77e

Conversation

@JulianMaurin

Copy link
Copy Markdown
Contributor

The dashboard moved to /orgs//repos//… routing; the retired
?login=&repository= query form no longer resolves, so the extension's
activity-log and merge-queue links (batch and non-batch) were landing on a dead
route. Build them through a shared getDashboardRepoBase() helper; the query
filters (pull_request, batch_pull, batch_pr, branch, pull-request-number) are
unchanged.

Test plan:

  • npx jest (72 passing) — every dashboard link asserts the path-scoped URL.
  • npx biome check — clean.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01KJbLFjMX9mb8o5T3JXTAXL

… URLs

The dashboard moved to /orgs/<org>/repos/<repo>/… routing; the retired
?login=&repository= query form no longer resolves, so the extension's
activity-log and merge-queue links (batch and non-batch) were landing on a dead
route. Build them through a shared getDashboardRepoBase() helper; the query
filters (pull_request, batch_pull, batch_pr, branch, pull-request-number) are
unchanged.

Test plan:
- npx jest (72 passing) — every dashboard link asserts the path-scoped URL.
- npx biome check — clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJbLFjMX9mb8o5T3JXTAXL
Change-Id: I3ea0d77ec82d5171847f15cba0e3d70356879454
Copilot AI review requested due to automatic review settings July 18, 2026 05:40
@JulianMaurin

JulianMaurin commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 fix: point the extension's dashboard links at the current path-scoped URLs #617 👈
2 test: re-record browser-extension fixtures on the current GitHub DOM, by era #618
3 feat: label merge-queue batch PRs with a pill and fix detection on the current DOM #616

@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 18, 2026 05:40 Failure
@mergify

mergify Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 2 of 6 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 👀 Review Requirements 👀 reviews
🔴 🔎 Reviews 👀 reviews
🟢 🤖 Continuous Integration
🟢 Enforce conventional commit
🟢 📕 PR description
🟢 🚦 Auto-queue

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by>=2
This rule is failing.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

Show 4 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify
mergify Bot requested a review from a team July 18, 2026 05:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the browser extension’s generated Mergify Dashboard links to use the newer path-scoped routing under /orgs/<org>/repos/<repo>/…, replacing the deprecated ?login=&repository= query-based URLs so links no longer land on dead routes.

Changes:

  • Added a shared getDashboardRepoBase() helper to centralize construction of the repo-scoped dashboard base URL.
  • Updated activity-log and merge-queue link builders to use the path-scoped base while preserving existing query filters.
  • Updated Jest expectations to assert the new path-scoped URLs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/queue.js Introduces getDashboardRepoBase() and switches dashboard link generation to path-scoped URLs.
src/tests/queue.test.js Updates assertions to match the new path-scoped dashboard URLs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants